feat(cluster): Add support for passing inheritedMetadata to Cluster spec #400
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cloudnative-pg#346) Utilized the tpl function to evaluate the owner string as a template inside the Helm template. --------- Signed-off-by: apriebeAVSystem <[email protected]> Co-authored-by: Itay Grudev <[email protected]> Signed-off-by: Zack Stevens <[email protected]>
Added inheritedMetadata to cluster.yaml Added inheritedMetadata to values.yaml with default value with commented example and references Added inheritedMetadata to values.schema.json Signed-off-by: Zack Stevens <[email protected]>
itay-grudev
requested changes
Dec 7, 2024
There was a problem hiding this comment.
Would you please be able to add a test for this in: https://github.com/cloudnative-pg/charts/tree/main/charts/cluster/test/postgresql-cluster-configuration
This tests whether non-default configuration properties get forwarded correctly and ensures we don't accidentally break something in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #326