-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat( cluster ): cluster.imageCatalogRef; ImageCatalog support; TimescaleDB support #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itay Grudev <[email protected]>
Co-authored-by: Булат Гафуров <[email protected]> Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
… the specs Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
paraddise
approved these changes
Jun 27, 2024
Signed-off-by: Itay Grudev <[email protected]>
jaredbischof
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and validated the TimescaleDB deployment in five different Kubernetes environments.
phisco
reviewed
Sep 4, 2024
Co-authored-by: Philippe Scorsolini <[email protected]> Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
phisco
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit convoluted for my taste, but it works as expected
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
hapeho
pushed a commit
to hapeho/cloudnative-pg-charts
that referenced
this pull request
Dec 18, 2024
…caleDB support (cloudnative-pg#306) * Added support for imageCatalogRef * Added support for custom ImageCatalog * Added support for TimescaleDB * Alternative postgresql version approach allowing for minor version in the specs Signed-off-by: Itay Grudev <[email protected]> Signed-off-by: Itay Grudev <[email protected]> Co-authored-by: Булат Гафуров <[email protected]> Co-authored-by: Philippe Scorsolini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster.imageCatalogRef
(@paraddise)imageCatalog
There is a bit of complication and checks, when using TimescaleDB, because the default
UID
andGID
need to be set to1000
, when using thetimescaledb-ha
docker image.This PR adds the following new field
version
that allows you to select the major PostgreSQL version, as well as TimescaleDB and PostGIS versions:P.S. The PR intentionally doesn't use the official
ClusterImageCatalog
s for backwards compatibility and instead setscluster.imageName
.Closes: #276
Closes: #297
Closes: #277