-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cluster): Recovery using pg_basebackup #252
feat(cluster): Recovery using pg_basebackup #252
Conversation
Signed-off-by: Pieter van der Giessen <[email protected]>
Signed-off-by: Pieter van der Giessen <[email protected]>
This is great work and we'll merge it, but I will request some changes. I'll allocate some time to do a detailed review later this week. |
When working on this, I didn't want to refactor the whole thing straight away, but indeed, to me it makes more sense to take it out of the recovery section |
Don't refactor it yet. Let's hear what @phisco thinks as well. But if we want to make that change it should be now, otherwise the API will be fixed for reasons of backwards compatibility. |
Also, we are testing "bootstrapping" databases using https://cloudnative-pg.io/documentation/1.22/database_import/. E.g.
Currently, I can specify the initdb part, but the externalClusters part would also need to be added. However, to me it feels a bit strange to add another part in the bootstrap where externalClusters are defined. Defining the externalClusters in the values.yaml and then using them one on one feels more natural to me, but maybe this is exactly the logic you want to abstract away with this helm chart. What do you think? |
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
Signed-off-by: Itay Grudev <[email protected]>
@Pionerd Sorry it took so long. This was a great work. I added some tests and changed the API so it feels more consistent with the rest of the chart. If you are already using this on production you may need to update your YAML a tiny bit. |
feat(cluster): Recovery using pg_basebackup (cloudnative-pg#252) --------- Signed-off-by: Pieter van der Giessen <[email protected]> Signed-off-by: Itay Grudev <[email protected]> Co-authored-by: Itay Grudev <[email protected]>
An implementation of the
pb_basebackup
recovery method.Tested this helm chart using the
existingSecret
option and was able to successfully bootstrap a cluster using this method. The TLS implementation I'm unable to test, but it is relatively straightforward, based on the docs.I assume you can automatically update the values schema / docs? Let me know if anything else is required.