Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(cluster): Propagate inheritFromAzureAD to the barman configuration #251

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

Pionerd
Copy link
Contributor

@Pionerd Pionerd commented Apr 8, 2024

Currently the cluster chart allows setting inheritFromAzureAD, but this is not propagated into the configuration.

@Pionerd Pionerd requested a review from itay-grudev as a code owner April 8, 2024 20:48
Pionerd added 2 commits April 8, 2024 22:49
Signed-off-by: Pieter <[email protected]>
@itay-grudev
Copy link
Collaborator

Have you tested this? I don't have access to such a setup, but it looks alright when checking the documentation.

@Pionerd
Copy link
Contributor Author

Pionerd commented Apr 8, 2024

I tested the configuration with a separate Cluster resource and validated that a helm template from this branch gives the same output.

@itay-grudev itay-grudev changed the title Use inheritFromAzureAD in cluster chart bugfix(cluster): Propagate inheritFromAzureAD to the barman configuration Apr 8, 2024
@itay-grudev itay-grudev merged commit 7347bce into cloudnative-pg:main Apr 8, 2024
4 checks passed
@itay-grudev itay-grudev added the chart( cluster ) Related to the cluster chart label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( cluster ) Related to the cluster chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants