Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudnative-pg): Support for additional labels in PodMonitor #196

Merged
merged 7 commits into from
Apr 3, 2024
Merged

feat(cloudnative-pg): Support for additional labels in PodMonitor #196

merged 7 commits into from
Apr 3, 2024

Conversation

cvrajeesh
Copy link
Contributor

@cvrajeesh cvrajeesh commented Feb 25, 2024 •
edited
Loading

Add support for additional labels to PodMonitor

monitoring:
  podMonitor:
    enabled: true
    additionalLabels:
       release: kube-prometheus-stack

Closes: #195

@cvrajeesh cvrajeesh force-pushed the feat/podmonitor-additional-labels branch from f594d97 to 5a5744e Compare February 25, 2024 09:31
@cvrajeesh cvrajeesh force-pushed the feat/podmonitor-additional-labels branch from 5a5744e to 1ac604d Compare March 4, 2024 12:46
@itay-grudev
Copy link
Collaborator

itay-grudev commented Mar 17, 2024 •
edited
Loading

We are very strict about backwards compatibility on anything that we consider stable.

As such however prettier, we unfortunately cannot accept the breaking change of renaming podMonitorEnabled to podMonitor.enabled.

I suppose the next best thing would be to call the label field: podMonitorAdditionalLabels.

itay-grudev and others added 5 commits April 3, 2024 12:14
@itay-grudev itay-grudev changed the title feat: Support for additional labels in PodMonitor feat(cloudnative-pg): Support for additional labels in PodMonitor Apr 3, 2024
@itay-grudev
Update values.schema.json
007106d 
Signed-off-by: Itay Grudev <[email protected]>
@itay-grudev itay-grudev merged commit b7e9e3e into cloudnative-pg:main Apr 3, 2024
4 checks passed
@itay-grudev itay-grudev added the chart( operator ) Related to the operator (cloudnative-pg) chart label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phisco phisco phisco approved these changes

@itay-grudev itay-grudev itay-grudev approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai fcanovai is a code owner

@gbartolini gbartolini Awaiting requested review from gbartolini gbartolini is a code owner

@leonardoce leonardoce Awaiting requested review from leonardoce leonardoce is a code owner

@mnencia mnencia Awaiting requested review from mnencia mnencia is a code owner

@sxd sxd Awaiting requested review from sxd sxd is a code owner

Assignees
No one assigned
Labels
chart( operator ) Related to the operator (cloudnative-pg) chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for additional labels in PodMonitor
3 participants
@cvrajeesh @itay-grudev @phisco