Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated the Grafana Dashboard into the operator chart #176

Merged
merged 8 commits into from
Feb 1, 2024

Conversation

itay-grudev
Copy link
Collaborator

This adds the CloudNativePG Grafana Dashboard to the operator chart.

There are two flags:

  • enabled (defaults to false) - whether to deploy the dashboard configmap
  • namespace - allows overriding the namespace where the chart is located.

Example:

helm install cnpg ./charts/cloudnative-pg \
  --namespace cnpg-system \
  --create-namespace \
  --set monitoring.grafanaDashboard.enabled=true \
  --set monitoring.grafanaDashboard.namespace=monitoring

@phisco
Copy link
Collaborator

phisco commented Jan 29, 2024

Thanks, @itay-grudev! Can you take care of updating all the other references to point to this file instead of https://github.com/cloudnative-pg/cloudnative-pg/blob/main/docs/src/samples/monitoring/grafana-configmap.yaml? IIRC the original reason we removed it from here was because we had some issues keeping the two in sync.

@itay-grudev
Copy link
Collaborator Author

itay-grudev commented Jan 29, 2024

@phisco I'll make sure to submit the changes to cloudnative-pg/cloudnative-pg the moment this PR gets merged.

charts/cloudnative-pg/values.yaml Outdated Show resolved Hide resolved
charts/cloudnative-pg/values.yaml Outdated Show resolved Hide resolved
charts/cloudnative-pg/values.yaml Outdated Show resolved Hide resolved
charts/cloudnative-pg/values.yaml Outdated Show resolved Hide resolved
charts/cloudnative-pg/values.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itay-grudev!

@phisco phisco force-pushed the grafana-dashboard branch from 544f026 to 99b037e Compare January 30, 2024 15:41
@gbartolini gbartolini merged commit 6c2bad2 into main Feb 1, 2024
3 checks passed
@gbartolini gbartolini deleted the grafana-dashboard branch February 1, 2024 13:39
itay-grudev added a commit that referenced this pull request Feb 4, 2024
* Automatically restart operator on config changes by @baurmatt in #172
* Integrated the Grafana Dashboard into the operator chart by @itay-grudev in #176
itay-grudev added a commit that referenced this pull request Feb 4, 2024
* Automatically restart operator on config changes by @baurmatt in #172
* Integrated the Grafana Dashboard into the operator chart by @itay-grudev in #176

Signed-off-by: Itay Grudev <[email protected]>
@itay-grudev itay-grudev added the chart( operator ) Related to the operator (cloudnative-pg) chart label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( operator ) Related to the operator (cloudnative-pg) chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants