Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudnative-pg): add metrics from cluster-example-monitoring.yaml #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Apr 27, 2023

This adds the metrics from cloudnative-pg/blob/docs/src/samples/cluster-example-monitoring.yaml

Since these metrics are in the sample, it is nice to have them in the defaults.

@phisco phisco self-requested a review April 27, 2023 15:35
@phisco
Copy link
Collaborator

phisco commented Apr 27, 2023

Good catch, thanks! But it looks like we are also missing a few other ones, no? I think it's because at some point we switched to deploying them by default with the plain manifests and forgot about updating them here. I'd rather not duplicate them though

@jcpunk
Copy link
Contributor Author

jcpunk commented Apr 27, 2023

I think this has all the same metrics as the sample files, but my by hand reconcile may have missed something...

@phisco
Copy link
Collaborator

phisco commented Apr 27, 2023

ok, now i got it, it's in sync with the default ones we deploy with manifests, see https://github.com/cloudnative-pg/cloudnative-pg/blob/main/releases/cnpg-1.20.0.yaml#L12160. The ones you are adding come from the example one: https://github.com/cloudnative-pg/cloudnative-pg/blob/main/docs/src/samples/cluster-example-monitoring.yaml#L27. I'm not sure it was a deliberate choice not to include those by default tbh, I'll have to check!

@jcpunk
Copy link
Contributor Author

jcpunk commented Apr 27, 2023

Interesting, I didn't realize they were also in the release yaml. I'd love for all 3 to have the same metrics. This way I've got a consistent metrics set in whichever mode I've loaded them from.

@phisco
Copy link
Collaborator

phisco commented Apr 27, 2023

Yes, either by adding or removing these everywhere. I'm checking if there was a reason not to include them in the default queries, i'll let you know 🙏

@itay-grudev itay-grudev changed the title feat: add metrics from cluster-example-monitoring.yaml feat(cloudnative-pg): add metrics from cluster-example-monitoring.yaml Apr 3, 2024
@itay-grudev itay-grudev added the chart( operator ) Related to the operator (cloudnative-pg) chart label May 25, 2024
This adds the metrics from cloudnative-pg/blob/docs/src/samples/cluster-example-monitoring.yaml

Since these metrics are in the sample, it is nice to have them in the
defaults.

Signed-off-by: Pat Riehecky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( operator ) Related to the operator (cloudnative-pg) chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants