Merge pull request #23 from cloudkite-io/knative-serving-resource-par…

…ameters Add support for `net-istio-controller` resource modifications
cloudkite-io · Jan 4, 2024 · 04c5d78 · 04c5d78
2 parents 2329eae + 47c0905
commit 04c5d78
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/knative-serving/templates/net-istio.yaml b/knative-serving/templates/net-istio.yaml
@@ -259,12 +259,7 @@ spec:
           # and substituted here.
           image: gcr.io/knative-releases/knative.dev/net-istio/cmd/controller@sha256:27e7beb7c62036216fc464fb2181e56b030158ad4ceb57a7de172f54b4fe43db
           resources:
-            requests:
-              cpu: 30m
-              memory: 40Mi
-            limits:
-              cpu: 300m
-              memory: 400Mi
+            {{- toYaml .Values.resources.netIstioController | nindent 12 }}      
           env:
             - name: SYSTEM_NAMESPACE
               valueFrom:

diff --git a/knative-serving/values.yaml b/knative-serving/values.yaml
@@ -2023,4 +2023,12 @@ configObservability:
     # the pods via an HTTP server in the format expected by the pprof visualization tool. When
     # enabled, the Knative Serving pods expose the profiling data on an alternate HTTP port 8008.
     # The HTTP context root for profiling is then /debug/pprof/.
-    profiling.enable: "false"
+    profiling.enable: "false"
+resources:
+  netIstioController:
+    requests:
+      cpu: 30m
+      memory: 40Mi
+    limits:
+      cpu: 300m
+      memory: 400Mi