-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MYPY Types added #97
MYPY Types added #97
Conversation
@const-cloudinary Does the initial changes looks good? |
Once you gives go ahead, I will implement the rest of the stubs and also add a precommit hook in the repository |
@gagandeepp , yeah looks great, please go ahead! |
@gagandeepp , this is what I see: |
|
@const-cloudinary Latest status: |
@const-cloudinary Can you please take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gagandeepp , Thank you for your PR!
This looks like a huge overhead of supporting such files, like, for every new option that is added, it needs to be added twice.
For example duplication of all @command
definitions, FORMAT_ALIASES
, not_callable
.
Isn't it better to combine pyi
and py
files into one?
If no, is there any sort of automation? Like GitHub action? To make sure we don't forget to update pyi
files ?
Let me take a look of |
Brief Summary of Changes
Fixes: cloudinary/pycloudinary#377
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist:
Before :
After: Old screenshot currently on 18 errors are there