Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable calc minification #2212

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Disable calc minification #2212

merged 1 commit into from
Sep 18, 2023

Conversation

tylersticka
Copy link
Member

Overview

We recently added our first styles that combine calc with clamp. cssnano's calc optimization does not like this combination (see an upstream dependency's related issue).

Disabling this optimization has two benefits:

  • It silences the warning we were receiving on build.
  • It actually decreases the file size after compression by a few bytes, presumably because the unoptimized expressions are more likely to recur throughout our stylesheet.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: a64cc6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit a64cc6b
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/65039c038f7470000798f1fb
😎 Deploy Preview https://deploy-preview-2212--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tylersticka tylersticka marked this pull request as ready for review September 14, 2023 23:52
@tylersticka tylersticka requested a review from a team September 14, 2023 23:52
Copy link
Member

@spaceninja spaceninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tylersticka tylersticka merged commit 9dbe23a into main Sep 18, 2023
@tylersticka tylersticka deleted the feature/tweak-cssnano-config branch September 18, 2023 16:08
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we disable the CSSNano calc optimization?
2 participants