Enhancements for SAML2 bearer and IdP initiated SSO #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* support resolution of SAMLResponse from request * remove default setting
the feature with classpath is new in this PR.
…0-registration-resolver # Conflicts: # server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/ConfiguratorRelyingPartyRegistrationRepository.java # server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/Saml2BearerGrantAuthenticationConverter.java
and create the data based on real key data Until now we do not deliver any keys in uaa.war.
…stration-resolver # Conflicts: # dependencies.gradle
…0-registration-resolver
Changed, because of hack with defaults.
duanemay
reviewed
Nov 15, 2024
...ava/org/cloudfoundry/identity/uaa/provider/saml/DefaultRelyingPartyRegistrationResolver.java
Outdated
Show resolved
Hide resolved
duanemay
reviewed
Nov 15, 2024
...rc/main/java/org/cloudfoundry/identity/uaa/provider/saml/SamlAuthenticationFilterConfig.java
Show resolved
Hide resolved
…strationResolver Signed-off-by: Duane May <[email protected]>
Signed-off-by: Duane May <[email protected]>
duanemay
approved these changes
Nov 15, 2024
Replace dummy-saml-idp-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI create also a full PR because sonar runs and helps to cleanup code, e.g.
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=3135
Includes #3132
In addition now created DefaultRelyingPartyRegistrationResolver which retrieves the correct registry / idp trust for the issuer.
We dont need the default return.
Open:
a) remove dummy -> in preparation
b) remove classpath: from idpMetadata , not need if a) is solved
c) refactorings, e.g. move the XML parsing from SAML2 bearer class into Saml2Utils