Feat(Forwarder Agent): Add a counter to track drops from egress diodes #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Emit a metric when envelopes in the egress diode for the OTel Collector are overwritten before being converted and sent - Removes OTel destination `Dropped 10000 envelopes for url 127.0.0.1:9100` log lines in favour of this new metric. Signed-off-by: Carson Long <[email protected]>
- Emit a metric when envelopes in the egress diode for Loggregator Servers are overwritten before being converted and sent - We considered emitting this metric as `dropped` with a direction of egress. We chose not to do that to avoid affecting existing dashboards that operate on the existing dropped direction=ingress metric. Signed-off-by: Andrew Crump <[email protected]>
acrmp
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emit a metric,
egress_expired_total, per Forwarder Agent egress destination to track the number of envelopes dropped from that designation's diode.Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack