Remove dependency credential test. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robdimsdale
commented
Jul 16, 2024
robdimsdale
commented
- With the change to the CFF-owned CDN, it no longer supports the use case of credentials in the dependency URL. So this test fails for environmental reasons.
- Given that this CDN is how consumers get their depedencies, and hence the entire feature no longer works for CFF consumers, it is reasonable to drop the test rather than try to find an alternative dependency store that accepts credentials.
- Phrased another way - even if we find a way to fix the test, the behavior it validates is not something consumers can use. So it is better to drop the test.
- With the change to the CFF-owned CDN, it no longer supports the use case of credentials in the dependency URL. So this test fails for environmental reasons. - Given that this CDN is how consumers get their depedencies, and hence the entire feature no longer works for CFF consumers, it is reasonable to drop the test rather than try to find an alternative dependency store that accepts credentials. - Phrased another way - even if we find a way to fix the test, the behavior it validates is not something consumers can use. So it is better to drop the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.