chore: improve help command output #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187221688 The labels on this github issue will be updated when the story is started. |
blgm
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Happy for this to be merged as it is. If I were being very fussy I would have suggested that "local" were turned into a constant rather than a repeated string, and rather than having a var that's used only once, I'd prefer to inline it like:
rootCmd.AddGroup(&cobra.Group{...})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
* [ ] Have you added or updated tests to validate the changed functionality?* [ ] Have you added Release Notes in the docs repositories?