fix: successfully delete instances and bindings with invalid state #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the upgrade epic, we added checks to make sure that service instances and bindings had been updated to the latest version. This involves parsing the Terraform state and extracting the version. But sometimes the Terraform state is not valid due to being empty, or being invalid JSON. Typically this is after a failure to provision/bind, and the service instance or binding is in a failed state. In these situations, the lack of state data means CSB does not have enough data to successfully clean up using Terraform. We have had feedback that this can be problematic for users because they have to do a manual purge of the service instance, and it would be easier if the delete operations would just work. This is a tradeoff because a manual purge could have the effect of triggering someone to look at the backing IaaS to look for resource leakage. By making this just work, we might make resource leakage worse. [#185835561](https://www.pivotaltracker.com/story/show/185835561)
pivotal-marcela-campo
force-pushed
the
nofailondelete
branch
from
cd9f0dc
to
7a9593b
Compare
pivotal-marcela-campo
approved these changes
Feb 23, 2024
|
LGTM. There is one scenario missing however, as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: please merge PR #954 first
As part of the upgrade epic, we added checks to make sure that service
instances and bindings had been updated to the latest version. This
involves parsing the Terraform state and extracting the version. But
sometimes the Terraform state is not valid due to being empty, or being
invalid JSON. Typically this is after a failure to provision/bind,
and the service instance or binding is in a failed state. In these
situations, the lack of state data means CSB does not have enough data to
successfully clean up using Terraform. We have had feedback that this
can be problematic for users because they have to do a manual purge of
the service instance, and it would be easier if the delete operations
would just work. This is a tradeoff because a manual purge could have
the effect of triggering someone to look at the backing IaaS to look for
resource leakage. By making this just work, we might make resource
leakage worse.
#185835561