test: more consistent error handling in integration tests #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the integration tests we were using the `must()` helper and also the `Expect(err).NotTo(HaveOccured())` pattern. Both are ok, but the code is cleaner when we are more consistent, and the `must()` pattern is more consise, so the tests were updated to use this pattern wherever possible.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186921655 The labels on this github issue will be updated when the story is started. |
pivotal-marcela-campo
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the integration tests we were using the
must()helper and also theExpect(err).NotTo(HaveOccured())pattern. Both are ok, but the code is cleaner when we are more consistent, and themust()pattern is more consise, so the tests were updated to use this pattern wherever possible.