Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable drain and running on vm #1097

Merged
merged 6 commits into from
Sep 13, 2024
Merged

feat: enable drain and running on vm #1097

merged 6 commits into from
Sep 13, 2024

Conversation

nouseforaname
Copy link
Contributor

Checklist:

  • Have you added or updated tests to validate the changed functionality?
  • Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

@nouseforaname nouseforaname changed the title feat:Feature enable drain and running on vm feat: enable drain and running on vm Sep 10, 2024
@nouseforaname nouseforaname force-pushed the feature_enable_drain_and_running_on_vm branch 4 times, most recently from 1a3f42e to 75befc5 Compare September 12, 2024 08:57
@nouseforaname
write lockfiles for in flight services
4be9b0d 
we need a mechanism for the bosh drain lifecycle to know if there are
terraform processes in flight. the lockfiles do just that. they filesystem
approach was favoured over a in memory map to allow an easier interface with
bosh. assuming the csb process crashes while shutting down, recovering the
SIs that were in flight is tricky because the in memory state got lost when
the crash happened.

additionally having the files use the GUIDs for their names allows us to log
the ecact SIs that were not succesfully finished via the drain script.
@nouseforaname nouseforaname force-pushed the feature_enable_drain_and_running_on_vm branch 3 times, most recently from a82daba to bb98a07 Compare September 12, 2024 09:31
@nouseforaname
add graceful shutdown
113605a 
we want to enable graceful shutdowns for the csb process so we can
ensure in flight terraform is able to finish before the broker process
exits. this hopes to make the broker more resilient against leaving orphaned
resources in the underlying IaaS.
@nouseforaname
move recover in progress to storage package
46824db
@nouseforaname
update tests to cover shutdown and updated recover in progress
fcb7872
@nouseforaname nouseforaname force-pushed the feature_enable_drain_and_running_on_vm branch from bb98a07 to fcb7872 Compare September 12, 2024 12:08
blgm
blgm approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@blgm blgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed and bar a few small improvements I'm happy with this.

integrationtest/termination_recovery_test.go Outdated Show resolved Hide resolved
integrationtest/termination_recovery_test.go Show resolved Hide resolved
integrationtest/termination_recovery_test.go Show resolved Hide resolved
internal/storage/recover_in_progress_operations.go Outdated Show resolved Hide resolved
internal/storage/terraform_deployment.go Outdated Show resolved Hide resolved
@nouseforaname nouseforaname merged commit d1a7c75 into main Sep 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blgm blgm blgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Service Management Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nouseforaname @blgm @FelisiaM