Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow HIL parser to parse CF request context by dropping annotation keys #1087

Closed
wants to merge 1 commit into from

Conversation

jameshochadel
Copy link
Contributor

Addresses #1086

Checklist:

  • Have you added or updated tests to validate the changed functionality?
  • Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

@jameshochadel jameshochadel changed the title Allow HIL parser to parse CF request context by dropping annotation keys fix: Allow HIL parser to parse CF request context by dropping annotation keys Sep 4, 2024
@kanngiesser
Copy link
Contributor

kanngiesser commented Sep 6, 2024

Removing org and space annotations from the request context will break our existing brokerpaks. I would propose to update the documentation to describe possible workarounds instead of removing data from the context object (See #1086 )

@jameshochadel
Copy link
Contributor Author

Closing in favor of documenting the workaround proposed by @kanngiesser on #1086.

@jameshochadel jameshochadel deleted the james-main branch September 6, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants