fix: only run database startup when running server #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error was discovered where database startup, including database migrations and failed operation recovery was being run for every command that accessed the database, including "tf dump". This had the effect of marking any in-progress operations as failed, even if they were still really in progress. This has been a problem since the introduction of in-progress operation recovery in v1.1.0 (commit c845267). [#187500102](https://www.pivotaltracker.com/story/show/187500102)
pivotal-marcela-campo
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error was discovered where database startup, including database migrations and failed operation recovery was being run for every command that accessed the database, including "tf dump". This had the effect of marking any in-progress operations as failed, even if they were still really in progress. This has been a problem since the introduction of in-progress operation recovery in v1.1.0 (commit c845267).
#187500102