This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Revert default installer location change and release 1.14.1 #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xortive
changed the title
xortive
changed the title
xortive
commented
Mar 5, 2021
| @@ -38,7 +38,7 @@ const getBinary = () => { | |||
| const customPath = | |||
| process.env.WRANGLER_INSTALL_PATH || | |||
| process.env.npm_config_wrangler_install_path; | |||
| const installDirectory = join(customPath || __dirname, "wrangler"); | |||
| const installDirectory = join(customPath || os.homedir(), ".wrangler"); | |||
There was a problem hiding this comment.
xtuc
approved these changes
Mar 5, 2021
|
Another approach could be using |
|
I'm still getting an error when using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had tested this using
npm pack, but it seems that when installing using the actual npm package, this change is causing issues for folks on npm@7. Let's revert to the known-good homedir install location until we figure out what's going on.I also included some edits to the release checklist that involve tagging the release after the release PR is merged. This makes fix and release PRs like this one work better, and it fixes some parts of github's CI that expect release tags to be tagged on the default branch
closes #1796