Force Handshake packet epoch if handshake hasn't been confirmed #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrittenhouse
force-pushed
the
evanrittenhouse/force-packet-epoch
branch
3 times, most recently
from
8c0784d
to
28dcb9d
Compare
evanrittenhouse
commented
Aug 28, 2024
evanrittenhouse
force-pushed
the
evanrittenhouse/force-packet-epoch
branch
2 times, most recently
from
decb16b
to
a040cde
Compare
…nfirmed The RFC states that an endpoint can immediately close a connection by sending a CONNECTION_CLOSE frame during the handshake: > However, prior to confirming the handshake, it is possible that more advanced packet protection keys are not available to the peer, so another CONNECTION_CLOSE frame MAY be sent in a packet that uses a lower packet protection level. Currently, when we decide the packet epoch when a CC frame is present, we always choose Application. This commit downgrades the epoch to Handshake if the handshake wasn't confirmed. The test added in this PR fails without this patch - since the packet is sent in the Application space without keys, the server can't decrypt it, so its `peer_error` is None.
evanrittenhouse
force-pushed
the
evanrittenhouse/force-packet-epoch
branch
from
a040cde
to
53185d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC states that an endpoint can immediately close a connection by
sending a CONNECTION_CLOSE frame during the handshake:
Currently, when we decide the packet epoch when a CC frame is present,
we always choose Application. This commit downgrades the epoch to
Handshake if the handshake wasn't confirmed.
The test added in this PR fails without this patch - since the packet is
sent in the Application space without keys, the server can't decrypt it,
so its
peer_erroris None.