Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement recovery and congestion control #1742

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Reimplement recovery and congestion control #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
baaac5a
Move RTT related stats and op to a separate struct
vkrasnov Dec 18, 2023
91d6173
Count bytes_in_flight outside congestion model
vkrasnov Feb 28, 2024
37fcca3
Merge epoch data into a struct
vkrasnov Mar 1, 2024
4be2dd9
Implement the loss detection timer as a struct
vkrasnov Mar 1, 2024
33dff36
Rewrite RttStats
vkrasnov Mar 1, 2024
8641ae0
Rewrite drain_packets
vkrasnov Mar 1, 2024
87835a5
Move detect acked packets logic to epoch
vkrasnov Mar 7, 2024
3f9bd59
Move all congestion control related fields to a new struct
vkrasnov Mar 8, 2024
8b8d204
Move congestion into module
vkrasnov Mar 8, 2024
ca809f3
Move reusable acks vec into Recovery
vkrasnov Mar 11, 2024
4adc646
Replace congestion control implementations with google/quiche congest…
vkrasnov Mar 12, 2024
df50522
Use nanosecond precision for Bandwidth
vkrasnov Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/src/bin/quiche-server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@ fn main() {
client.loss_rate = loss_rate;
}

#[allow(deprecated)]
let max_send_burst =
client.conn.send_quantum().min(client.max_send_burst) /
client.max_datagram_size *
Expand Down
1 change: 1 addition & 0 deletions quiche/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ pkg-config = { version = "0.3", optional = true }

[dependencies]
either = { version = "1.8", default-features = false }
enum_dispatch = "0.3"
log = { version = "0.4", features = ["std"] }
libc = "0.2"
libm = "0.2"
Expand Down
10 changes: 8 additions & 2 deletions quiche/src/ffi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,7 +1459,10 @@ pub extern fn quiche_conn_peer_streams_left_uni(conn: &Connection) -> u64 {

#[no_mangle]
pub extern fn quiche_conn_send_quantum(conn: &Connection) -> size_t {
conn.send_quantum() as size_t
#[allow(deprecated)]
{
conn.send_quantum() as size_t
}
}

#[no_mangle]
Expand Down Expand Up @@ -1540,7 +1543,10 @@ pub extern fn quiche_conn_send_quantum_on_path(
let local = std_addr_from_c(local, local_len);
let peer = std_addr_from_c(peer, peer_len);

conn.send_quantum_on_path(local, peer) as size_t
#[allow(deprecated)]
{
conn.send_quantum_on_path(local, peer) as size_t
}
}

#[no_mangle]
Expand Down
Loading