Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo quick start doc snippet #46

Closed
wants to merge 1 commit into from

Conversation

kristianpaul
Copy link
Contributor

Solves #45

@eaufavor eaufavor added documentation Improvements or additions to documentation Accepted This change is accepted by us and merged to our internal repo labels Mar 1, 2024
@eaufavor
Copy link
Member

eaufavor commented Mar 1, 2024

We changed it a slightly different way.

@eaufavor eaufavor closed this Mar 1, 2024
@kristianpaul
Copy link
Contributor Author

@eaufavor There are no changes (8160ad1) fixing that snippet of code,

can you elaborate how you changed it? the changes are not reflected and the quick-start still broken which i personally think is bad, even ifs its a small typo... copy and paste code should always run, its bad experience for starters when it doesnt

paul@rock0:~/load_balancer $ cargo run
   Compiling load_balancer v0.1.0 (/mnt/home/pi/load_balancer)
error: invalid format string: expected `'}'`, found `'?'`
  --> src/main.rs:36:47
   |
36 |         println!("upstream peer is: {:upstream?}");
   |                                     -         ^ expected `'}'` in format string
   |                                     |
   |                                     because of this opening brace
   |
   = note: if you intended to print `{`, you can escape it using `{{`

error: could not compile `load_balancer` (bin "load_balancer") due to 1 previous error
paul@rock0:~/load_balancer $ date
Mon Mar  4 03:49:51 PM UTC 2024

@eaufavor
Copy link
Member

eaufavor commented Mar 4, 2024

Oh you are right. I just noticed that I accidentally dropped that commit when pushing the change. We will fix it soon. Thanks!

@eaufavor eaufavor reopened this Mar 4, 2024
@kristianpaul
Copy link
Contributor Author

Oh you are right. I just noticed that I accidentally dropped that commit when pushing the change. We will fix it soon. Thanks!

I would have just merged the PR so what was the point of it anyway?, it was an easy fix... but thanks for noticing my comments hope you can keep improving the docs..

@johnhurt johnhurt removed the Accepted This change is accepted by us and merged to our internal repo label Mar 7, 2024
@andrewhavck
Copy link
Contributor

Thanks, the commit referenced here is now synced, closing this.

@andrewhavck andrewhavck closed this Mar 8, 2024
@kristianpaul kristianpaul deleted the patch-1 branch March 11, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants