Only compile pingora-openssl and its deps when openssl is enabled. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samurai00
force-pushed
the
optimize-ssl-feature-dep
branch
from
2f68666
to
af5575d
Compare
samurai00
force-pushed
the
optimize-ssl-feature-dep
branch
from
af5575d
to
ae706cd
Compare
andrewhavck
added
the
Accepted
|
This has been merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
boringsslshould only compilepingora-boringsslbutpingora-opensslstill gets compiled. This is not what I expected.This PR fixes this issue by updating the
Cargo.tomlfiles for several crates to setdefault-featurestofalse. This ensures that theopensslfeature ofpingora-coreand its dependencypingora-opensslare only depended on when theopensslfeature is enabled.