Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data based on atlas traceroutes #398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kroeckx
Copy link

@kroeckx kroeckx commented May 21, 2020

This also contains the commit from #397

The signing is based on what https://rpki.cloudflare.com/?view=bgp
returns. It's probably not ideal, but it's the best I know.
I have used:
< 10% valid signatures: not signing
> 90% valid signatures: signing
otherwise: partial signing
@lspgn
Copy link
Contributor

lspgn commented May 21, 2020

Hello,
Could you detail a bit the process with Atlas traceroutes? Does it include the false positives?
I prefer putting only what the network does. Makes it easier to read than "not filtering".
There are also more states with partial filtering which would need to be featured.

This rewrites every line and reviewing it is a considerable amount of work.

@kroeckx
Copy link
Author

kroeckx commented May 21, 2020 via email

@kroeckx
Copy link
Author

kroeckx commented May 30, 2020

First let's properly define the terms.
False positive: It looks like their filtering, but they're not
False negative: It looks like their not filtering, but they are

Examples of false positive:

  • There was just some network problem at the time
  • They're not filtering, but all (or their only) transit provider(s) is filtering
  • They're only filtering some peers
  • They're only partially filtering, because for whatever reason they can't filter all ranges
  • They're actually just filtering some known test ranges

Examples of false negatives:

  • They are filtering, but they have a default route to one of their transit providers that doesn't filter

Since it's all results for where it could reach an invalid route, it can not contain false positives, but can contain false negatives. It can mark things that are partially filtering as not filtering, but if that's the case, they can just open a pull request to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants