Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix certmgr 3.0.3 URIs #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

srhb
Copy link

@srhb srhb commented Aug 2, 2024

This PR is really about fixing the validation of URI SANs that was broken since certmgr switched to using the cfssl transport (I think...)

This prevents constant reissuance when the SANs contain URIs.

However, in order to even support URIs properly like the old certmgr 1.x, the cfssl dependency needs to be bumped. To make my life easier, this PR contains a cursed direct patch of the vendored cfssl -- specifically cloudflare/cfssl#1157

This should obviously be removed if ever the ancient cfssl is updated or unvendored.

Until then, the TMP commit makes this PR apply cleanly as a patch on top of v3.0.3

srhb added 2 commits August 2, 2024 09:35
Since a new release doesn't seem forthcoming, this seems to make this PR
complete wrt. supporting sane reissuance of URI-containing specs
@srhb srhb changed the title Draft: Fix certmgr 3.0.3 uris Draft: Fix certmgr 3.0.3 URIs Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant