Refactor!: Remove strict TokioIo response requirement from hyper_boring::v1::HttpsConnector
#305
+27
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
reviewed
Dec 6, 2024
…oring::v1::HttpsConnector` Closes cloudflare#295. Signed-off-by: Paul Mabileau <[email protected]>
PaulDance
force-pushed
the
hyper1-remove-tokioio
branch
from
9223c4a to
ca35238
Compare
|
Having the ability to run the CI would be quite useful at this point, please. |
kornelski
approved these changes
Dec 7, 2024
|
Thanks! Since this will conflict with #304 that needs to be changed, I guess the current PR can be merged as-is and conflicts will be resolved in the other one after rebasing. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295. Should probably follow after #304. Requires breaking changes as well.