Skip bindgen 0.70's layout tests before Rust 1.77 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushilmehra
approved these changes
Oct 22, 2024
|
(The macOS -> Linux FIPS cross-build job is failing on main too; it is unrelated to this PR.) |
Tracked by #285 |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/signalapp/libsignal currently supports building with Rust 1.75, but bindgen's compile-time layout tests (introduced in 0.70) require a newer Rust version. But the rest of bindgen 0.70's output is perfectly valid on 1.75 (I diffed the files to check that there were no other changes).