Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to build for all matrix targets #188

Merged
merged 15 commits into from
Dec 14, 2023
Merged

Update CI to build for all matrix targets #188

merged 15 commits into from
Dec 14, 2023

Conversation

eager-signal
Copy link
Contributor

We noticed that the CI matrix wasn’t always building for the Rust target it intended, leading to surprise breakage (e.g. #187) when doing release builds. This addresses that in a few ways:

  1. add --target to cargo test
  2. check_only flag
    • skip running tests for non-native architectures and targets; instead do cargo build … --tests to confirm cross-compilation
  3. various customization options
    • specific packages required to cross-compile for the target, environment variables, etc.
  4. last resort: drop a target
    • musl doesn’t have a standard C++ setup to use

@jrose-signal jrose-signal mentioned this pull request Nov 17, 2023
Merged
@nox
Copy link
Collaborator

nox commented Nov 30, 2023

Thanks for the impressive PR! Can you please rebase on top of master now that #187 is merged? Thanks.

eager-signal and others added 15 commits November 30, 2023 13:15
@eager-signal
Add relevant --target to cargo test in CI
07f86da
@eager-signal
Refactor check-only and extra-test-args
31fb60c
@eager-signal
Add matrix.apt_packages
9d1a81a
@eager-signal
Make arm and Android builds check-only
9d01c7c
@jrose-signal @eager-signal
Remove musl test; there's no standard musl C++ setup for us to use
a64dc35
@eager-signal
Build tests even for cross-compiling
704c6e4
@jrose-signal @eager-signal
Add custom environment for ARM Linux cross-compilation
81ef8b4
@jrose-signal @eager-signal
Add custom linker for Android cross-compilation
2bb1d3d
@jrose-signal @eager-signal
Add arm64-macos cross-compile to CI
a5bbe4b
@jrose-signal @eager-signal
Always run tests in bash
03c532f 
This is only necessary for the windows-gnu target, but causes no
issues anywhere else.
@jrose-signal @eager-signal
Use gcc/g++ as the compilers for windows-gnu, not Clang
34fc414
@jrose-signal @eager-signal
boring-sys: Don't check for MSVC with target_env
bb58482 
x86_64-pc-windows-gnu is identified as `target_env = "msvc"` too,
but doesn't use the Visual Studio CMake generator.
@jrose-signal @eager-signal
boring-sys: Blocklist max_align_t in bindgen
27b1e26 
rust-lang/rust-bindgen#1823
@eager-signal
Remove unused target_env from boring-sys build config
a6e882e
@eager-signal
Swap build and run order; always build
789b6a2
@eager-signal
Copy link
Contributor Author

Can you please rebase on top of master now that #187 is merged? Thanks.

@nox yep, done!

@jrose-signal
Copy link
Contributor

Fixes #62 :-)

@nox nox merged commit dd281f6 into cloudflare:master Dec 14, 2023
23 checks passed
@eager-signal eager-signal deleted the ci_matrix_targets branch December 14, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox nox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eager-signal @nox @jrose-signal