Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp and azure cloud provider integrated #115

Merged
merged 7 commits into from
Oct 25, 2024
Merged

gcp and azure cloud provider integrated #115

merged 7 commits into from
Oct 25, 2024

Conversation

Bharadwajshivam28
Copy link
Member

what

  • Integrated GCP cloud provider in kuconf
  • Formatted files and folder structure
  • Improved cli to keep cloud provider name as prefix

@anmolnagpal
Copy link

@Bharadwajshivam28 pls fix the tests

@anmolnagpal anmolnagpal marked this pull request as draft October 24, 2024 21:03
@anmolnagpal anmolnagpal added the enhancement New feature or request label Oct 24, 2024
@anmolnagpal anmolnagpal marked this pull request as ready for review October 25, 2024 13:11
@Bharadwajshivam28 Bharadwajshivam28 changed the title GCP cloud provider integration gcp and azure cloud provider integrated Oct 25, 2024
nikitadugar
nikitadugar approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!LGTM

@nikitadugar nikitadugar merged commit d060a72 into clouddrove:main Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitadugar nikitadugar nikitadugar approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@Bharadwajshivam28 Bharadwajshivam28

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bharadwajshivam28 @anmolnagpal @nikitadugar