-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip #112
base: master
Are you sure you want to change the base?
wip #112
Conversation
not tested at all, does not even compile yet |
I'm very interested in dumping axios in favor of the built-in fetch. I run a lot of things in cloudflare workers and this would be quite a helpful change. Any update on when this might be ready? |
I'm ready to continue with this, I was just hoping for pointers regarding #111 (comment) before I go ahead. Shipping a custom implementation of multipart/form-data clearly gives us the best library, but I didn't feel like deciding alone whether or not we want to accept that in this library. |
Sorry for the delay. We should go with a custom multipart/form-data implementation then as @KnorpelSenf suggested. I think we need to keep the optional |
Alright, I will commence my work on this in the coming time, but my time for OSS is a bit limited right now, so please don't expect an immediate implementation :)
What if somebody passes a read stream, or an |
Unfortunately, S3 strictly requires the In the mentioned example the server should return a |
Alright!
Yeah I'll add this to the doc string |
Hi @KnorpelSenf - I see you've mentioned you won't be able to dedicate much time to this PR - but regardless I'm going to ask! Do you have a rough timeframe here? |
Yep, I'm gonna give a talk at https://events.geekle.us/typescript24/ on Tuesday so there are a number of things to prepare until then. The rest of that week will be spent catching up with life in general, and the week after that I'm mostly free and looking forward to getting back to this (but no promises, life can be surprising and I don't want to set myself deadlines) |
If you feel like contributing, you can check out the base implementation of what I'll do here in this file: https://github.com/grammyjs/grammY/blob/main/src/core/payload.ts |
I will get back to this after my summer vacation, likely in September. Sorry for the delays, there were a few other important tasks on my agenda :) |
Closes #111.