Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): support object-based MF2 exposed modules in ModuleFeder… #50

Conversation

steven-pribilinskiy
Copy link
Collaborator

This pull request includes several changes to the compileTypesWorker tests and the ModuleFederationTypesPlugin to handle exposed modules as objects rather than arrays. The most important changes include updating the test cases and modifying the exposes handling logic in the plugin.

Updates to test cases:

Plugin modifications:

  • src/compileTypes/compileTypes.ts: Updated the CompileTypesParams type to use a dictionary (Dict<string>) for exposedModules instead of an array.
  • src/plugin.ts: Added logic to handle exposes as objects with import and name properties, and updated the compileTypesAsync call to use the new exposedModules structure. [1] [2]

@steven-pribilinskiy steven-pribilinskiy requested a review from a team as a code owner December 13, 2024 12:46
@steven-pribilinskiy steven-pribilinskiy merged commit 2470fdd into main Dec 13, 2024
3 checks passed
@steven-pribilinskiy steven-pribilinskiy deleted the feat/support-object-based-MF2-exposed-modules-in-ModuleFederationTypesPlugin branch December 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants