Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compileTypesAsync): improve worker termination logic #49

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

steven-pribilinskiy
Copy link
Collaborator

@steven-pribilinskiy steven-pribilinskiy commented Oct 23, 2024

Improve worker termination logic to enhance the handling of active worker instances.

Graceful termination yields to unnecessary CPU usage

What has been changed?

  • Updated the worker termination logic to manage multiple active workers using a Map.
  • Removed references to the ExitMessage type which is no longer needed.
  • Enhanced logging to reflect the current worker index when compiling types.

Before

image

After

image

made with gpt-4o-mini using common rules

@steven-pribilinskiy steven-pribilinskiy requested a review from a team as a code owner October 23, 2024 13:47
@steven-pribilinskiy steven-pribilinskiy merged commit 13384f8 into main Oct 24, 2024
3 checks passed
@steven-pribilinskiy steven-pribilinskiy deleted the fix/worker-termination branch October 24, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants