Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: substitute aliased modules #39

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

steven-pribilinskiy
Copy link
Collaborator

@steven-pribilinskiy steven-pribilinskiy commented Feb 19, 2024

We have an issue with nested import resolution when typings are generated

image

that results in any type since TS cannot find module "contracts/types" in the consuming MFE

image

As a solution, we'll replace all import() paths with existing ones from the exposed federated module

Result

image

image

image


Also removed excessive empty space for node_modules

image

@steven-pribilinskiy steven-pribilinskiy merged commit ef645ba into main Feb 20, 2024
5 checks passed
@steven-pribilinskiy steven-pribilinskiy deleted the substitute-aliased-paths branch February 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants