Improve error messages in garm log

[maigl]

finding errors in logs is very important and there are some logs that are errors but seem to be rather normal:

• workflow events without labels -> this happens very often (at least in our GHE instance), this might be a bug in github code .. but garm probably has to accept this and don't consider this an error
• workflows that have runner_names which are not our runners. This always happens in a scenario where our garm runners are not the only runner setup (and we still get the workflow_job events, e.g. enterprise wide hooks)

[gabriel-samfira]

Thanks! I should have added more context to those messages.

[gabriel-samfira]

same as above. The level change to DebugContext is fine.

[gabriel-samfira]

I think we need to bump golangci-lint to >= 1.60.1. Details here: golangci/golangci-lint#4662 (comment)

[maigl]

I added a specific golangci-lint version in the Makefile .. now we're left with a bunch of G115: integer overflow conversion findings .. I think they are okayish .. how to deal with them, exclude G115?

[gabriel-samfira]

Yeah. Let's exclude them for now. I don't think anyone will try to set 2^32 MaxRunners. Anytime soon. We may change the types later to avoid the need to convert, or add some overflow checks. But for now, let's jut exclude them.

[maigl]

Yeah. Let's exclude them for now. I don't think anyone will try to set 2^32 MaxRunners. Anytime soon. We may change the types later to avoid the need to convert, or add some overflow checks. But for now, let's jut exclude them.

done

[gabriel-samfira]

Thanks @maigl !