Add unit tests for coriolis.db.sqlalchemy.* modules
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dany9966
requested changes
Jul 10, 2024
| class DatabaseSqlalchemyApiTestCase(test_base.CoriolisBaseTestCase): | ||
|
|
||
| @mock.patch.object(db_session, 'EngineFacade') | ||
| def test_get_facede_none(self, mock_EngineFacade): |
There was a problem hiding this comment.
NIT: please rename in order to fix typo: test_get_facade_none
| mock_EngineFacade.assert_called_once_with(mock.sentinel.connection) | ||
|
|
||
| @mock.patch.object(db_session, 'EngineFacade') | ||
| def test_get_facede(self, mock_EngineFacade): |
There was a problem hiding this comment.
Same as above, rename into test_get_facade
| ) | ||
| mock_db_sync.assert_called_once_with( | ||
| mock.sentinel.engine, | ||
| mock.ANY, |
There was a problem hiding this comment.
Instead of passing mock.ANY, let's please mock os.path.abspath, make it return something like "/abspath". Then you can replace this with "/abspath/migrate_repo". Please apply this to all of these test methods
Cristi1324
force-pushed
the
add_db_sqlalchemy_unit_tests
branch
from
9b4abc6
to
0d2467a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add unit tests for
coriolis.db.sqlalchemy.*modules