Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Update test server config #445

Merged
merged 2 commits into from
May 13, 2021
Merged

Update test server config #445

merged 2 commits into from
May 13, 2021

Conversation

ricellis
Copy link
Member

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Change the test server configuration and allow for overriding the token server used by tests.

1. Steps to reproduce and the simplest code sample possible to demonstrate the issue

Run Jenkins tests

2. What you expected to happen

Tests to pass

3. What actually happened

Tests failed because of a server config problem.

Approach

Replace the test server configuration in Jenkinsfile.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

  • Modified existing IAM auth plugin tests to use configured IAM token server when not nocked.

Monitoring and Logging

  • "No change"

@ricellis ricellis marked this pull request as ready for review May 13, 2021 14:29
@ricellis ricellis self-assigned this May 13, 2021
Copy link
Contributor

@mojito317 mojito317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1

@ricellis ricellis added this to the 4.next milestone May 13, 2021
@ricellis ricellis merged commit 49ac32a into master May 13, 2021
@ricellis ricellis deleted the new-test-server branch May 13, 2021 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants