Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ECR tag detection #1786

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix ECR tag detection #1786

merged 3 commits into from
Sep 26, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Sep 26, 2024 •
edited
Loading

Changes proposed in this pull request:

Related to https://github.com/cloud-gov/private/issues/1439

  • Add provider with default tags so that it does not always detect changes on tags
  • True up database version for Defect Dojo

security considerations

None, just improving Terraform

@markdboyd markdboyd requested a review from a team as a code owner September 26, 2024 14:31
dandersonsw
dandersonsw approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@dandersonsw dandersonsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ty!

@markdboyd markdboyd merged commit dec3c8c into main Sep 26, 2024
3 checks passed
@markdboyd markdboyd deleted the fix-ecr-tag-detection branch September 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutenniza soutenniza soutenniza approved these changes

@dandersonsw dandersonsw dandersonsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdboyd @soutenniza @dandersonsw