Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust domains broker perms #1716

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Adjust domains broker perms #1716

merged 2 commits into from
Aug 5, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

This recommendation came from an interaction with AWS support. Without the permission ListServerCertificates on all (*) resources, a DeleteServerCertificate request for an already deleted certificate will throw a 403 error.

From AWS:

This occurs because the DeleteServerCertificate operation includes both list and delete APIs. The list API checks for the presence of certificates, but if no matching certificate exists within the specified path, it assumes the certificate is elsewhere. Due to the path limitation, it cannot verify this, leading to the 403 error.

security considerations

ListServerCertificates is a read-only operation, so there should be no danger to giving it access to list other certificates.

@markdboyd markdboyd requested a review from a team as a code owner August 5, 2024 14:49
@markdboyd markdboyd merged commit 234ebee into main Aug 5, 2024
3 checks passed
@markdboyd markdboyd deleted the adjust-domains-broker-perms branch August 5, 2024 14:53
@markdboyd markdboyd mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants