Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: including typehints; tox to manage packages; mypy to static check; remove unnecessary requirements; change circle ci to use tox; run black and isort to format #118

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@ defaults: &defaults
- checkout
- run:
name: Install dependencies
command: pip install -r requirements.txt
command: pip install tox
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to move away from using CircleCI and towards github actions. Would you mind holding off any changes to CircleCI config?

- run:
name: Test
command: pytest
command: tox -e py
- run:
name: Mypy
command: tox -e mypy

jobs:
test-3.7:
Expand Down
38 changes: 38 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,44 @@ lead_results = api.get('lead', params={

Check out [https://github.com/closeio/closeio-api-scripts](https://github.com/closeio/closeio-api-scripts) for helpful scripts already written to accomplish some common tasks.


### Contributions
We welcome contributions to this project! To get started, follow these steps to set up your environment:

- Fork the repository

- Create a virtual environment
```sh
python3 -m venv venv
source source venv/bin/activate
```
- Install dependencies
```sh
pip install -r requirements.txt
```

- Install `tox` for development purposes
```sh
pip install tox
```

- Run `tox` to execute tests, type checks, and formatters
```sh
tox
```
- To run only tests:
```sh
tox -e py
```
- To run only the formatter:
```sh
tox -e format
```
- To run only type checks with mypy:
```sh
tox -e mypy
```

### Other Languages

There are unofficial API clients available in other languages too, thanks to some awesome contributors:
Expand Down
Loading