Cleaned up pool thread names and added test for failing parking ops

clojure · Jan 24, 2025 · a6151f2 · a6151f2
1 parent 3158bb7
commit a6151f2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/main/clojure/clojure/core/async.clj b/src/main/clojure/clojure/core/async.clj
@@ -463,10 +463,10 @@ to catch and handle."
   (#'clojure.core.async.impl.go/go-impl &env body))
 
 (defonce ^:private ^Executor thread-macro-executor
-  (Executors/newCachedThreadPool (conc/counted-thread-factory "async-thread-macro-%d" true)))
+  (Executors/newCachedThreadPool (conc/counted-thread-factory "async-thread-%d" true)))
 
 (defonce ^:private ^ExecutorService io-thread-exec
-  (Executors/newCachedThreadPool (conc/counted-thread-factory "io-thread-macro-%d" true)))
+  (Executors/newCachedThreadPool (conc/counted-thread-factory "async-io-thread-%d" true)))
 
 (defn thread-call
   "Executes f in another thread, returning immediately to the calling

diff --git a/src/test/clojure/clojure/core/async_test.clj b/src/test/clojure/clojure/core/async_test.clj
@@ -186,14 +186,22 @@
       (is (<!! (thread test-dyn))))))
 
 (deftest io-thread-tests
-  (testing "io-thread"
+  (testing "io-thread blocking ops"
     (let [c1 (chan)
           c2 (chan)
           c3 (chan)]
       (io-thread (>!! c2 (clojure.string/upper-case (<!! c1))))
       (io-thread (>!! c3 (clojure.string/reverse (<!! c2))))
       (>!! c1 "loop")
-      (is (= "POOL" (<!! c3))))))
+      (is (= "POOL" (<!! c3)))))
+  (testing "io-thread parking op should fail"
+    (let [c1 (chan)]
+      (io-thread
+       (try
+         (>! c1 :no)
+         (catch AssertionError _
+           (>!! c1 :yes))))
+      (is (= :yes (<!! c1))))))
 
 (deftest ops-tests
   (testing "map<"