Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cider-log-show-frameworks command #3753

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

r0man
Copy link
Contributor

@r0man r0man commented Oct 29, 2024

This command renders the available log frameworks in a buffer. It shows the log framework name, the website and javadocs urls and the levels for now.

This is mostly to address @vemv's suggestion to ask the user to run (cider-sync-request:log-frameworks). I hooked the command up at the usual places and added it with a small troubleshooting section to the docs.

We could get even more sophisticated and show the current appenders and consumers but I need a user interface designer for this. Let's do this at some other point.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@vemv
Copy link
Member

vemv commented Oct 29, 2024

Thanks a lot!

LGTM, but I cannot do a particularly deep dive atm.

btw, one thing that you might want to hammock is the behavior of selecting the sole available framework if there's only one.

Maybe we can keep the behavior but also (message "cider-log-mode: only one framework available, auto-selecting <framework>"). That way we leave something in the 'logs' so that things are less surprising when they go wrong.

Cheers - V

cider-log.el Outdated Show resolved Hide resolved
cider-log.el Outdated Show resolved Hide resolved
cider-log.el Outdated Show resolved Hide resolved
cider-log.el Outdated Show resolved Hide resolved
@r0man r0man force-pushed the cider-log-frameworks branch 2 times, most recently from 4e2ea0e to 9654792 Compare October 30, 2024 20:27
@r0man r0man changed the title Add cider-log-frameworks command Add cider-log-show-frameworks command Oct 30, 2024
This command renders the available log frameworks in a buffer. It
shows the log framework name, the website and javadocs urls and the
levels for now.

This is mostly to address @vemv's suggestion to ask the user to run
`(cider-sync-request:log-frameworks)`. I hooked the command up at the
usual places and added it with a small troubleshooting section to the
docs.

We could get even more sophisticated and show the current appenders
and consumers but I need a designer for this. Let's do this at some
other point.
@bbatsov bbatsov merged commit 52016de into clojure-emacs:master Oct 31, 2024
39 checks passed
@bbatsov
Copy link
Member

bbatsov commented Oct 31, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants