Fix declaration order of ScheduleAt in C# #2007
Open
+584
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm this doesn't look right. It seems it's Rust that is wrong here as C# implemented the enum according to the spec: https://github.com/clockworklabs/SpacetimeDBPrivate/blob/592a34c0cb82d587843d2b2309b824e94c035d26/proposals/0005-timers.md?plain=1#L82 Or, I guess, we can do this PR, but then we need to change the spec as well. |
RReverser
reviewed
Nov 22, 2024
| new("Interval", new AlgebraicType.U64(default)), | ||
| new("Time", new AlgebraicType.U64(default)), |
There was a problem hiding this comment.
FWIW this is the only necessary reordering, the rest don't matter and can be safely reverted.
There was a problem hiding this comment.
I figured, but I thought we might as well update all of them for consistency.
|
Ah whoops. I think it's probably easier to change the spec at this point as it's less of a breaking change. |
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add some tests to sdk-test-cs. This was causing
ScheduleAtto not get recognized by the schema validation code.These tests don't fully exercise scheduling/indexes yet, but at least they check if they compile & are accepted by the host.
Expected complexity level and risk
0
Testing
Added tests.