Fix inference for UNION #1994
Open
Fix inference for UNION #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
added
bugfix
mamcx
commented
Nov 13, 2024
| pub fn compile_sql_stmt<'a>(sql: &'a str, tx: &impl SchemaView) -> TypingResult<StatementCtx<'a>> { | ||
| let statement = parse_and_type_sql(sql, tx)?; | ||
| pub fn compile_sql_stmt<'a>(ctx: &mut TyCtx, sql: &'a str, tx: &impl SchemaView) -> TypingResult<StatementCtx<'a>> { | ||
| let statement = parse_and_type_sql(ctx, sql, tx)?; |
There was a problem hiding this comment.
This makes both compile_xxx functions share the same signature, is useful for later PRs...
mamcx
force-pushed
the
mamcx/fix_typecheck_union
branch
from
5535d3f
to
31776c0
Compare
|
bots please (doing this for unrelated reasons to this PR) |
|
Bot test failed. Please check the workflow run for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When trying to infer the type for
UNIONlike queries we get:Unexpected type: (expected) (u32: U32f32: F32str: String) != (u32: U32f32: F32str: String) (inferred)Because the check is only 'nominal' (aka: test both
table_idare the same), this patch also makes a structural check.Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!