Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-aliasing is a 30x performance hit for me. #177

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

paulrd
Copy link
Contributor

@paulrd paulrd commented Aug 30, 2014

I'm not sure if anti-aliasing should be on by default given the drastic performance hit. Should it be optional to turn it off? Or off by default?

I'm not sure if anti-aliasing should be on by default given the drastic performance hit. Should it be optional to turn it off? Or off by default?
@paulrd
Copy link
Contributor Author

paulrd commented Aug 30, 2014

I don't know why travis CI is failing (EOF while reading?), but ./lazytest.sh passes on my box as does lein test.

@daveray
Copy link
Collaborator

daveray commented Aug 30, 2014

Looks like the closing paren is missing on your (when anti-alias? ... form.

Otherwise, this change seems reasonable given that it doesn't change the default behavior. Anti-aliasing hasn't caused me major problems in the past and no one else has complained. What platform?

@paulrd
Copy link
Contributor Author

paulrd commented Aug 30, 2014

I'm using 64 bit Ubuntu 14.04 and
java version "1.7.0_65"
OpenJDK Runtime Environment (IcedTea 2.5.1) (7u65-2.5.1-4ubuntu1~0.14.04.2)
OpenJDK 64-Bit Server VM (build 24.65-b04, mixed mode)

I'd be interested to see if anyone gets the same slow-down. I suppose there aren't many people doing intense custom painting in their swing components via seesaw. The difference between 1ms and 30 ms isn't a big deal on a gui, but if you're doing something that takes 1 second long, 30 seconds is a long time. Glad to have a easy way to turn it off.

I was working through the examples in the Filthy Rich Clients book by Chet Haase and Romaine Guy. I was looking at the CopyAreaPerformance example and noticed my clojure version was taking 25 seconds to paint and theirs was sub 200 ms (there are other slowdowns to find, but anti-aliasing was the biggest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants