Skip to content

Commit

Permalink
Revert "Pass collectDelay arg to Clinic Doctor/Flame (#208)"
Browse files Browse the repository at this point in the history
This reverts commit e6db361.
  • Loading branch information
goto-bus-stop committed May 29, 2020
1 parent 3f0d848 commit 8f47ecd
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 16 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,3 @@ typings/
.vscode
# IntelliJ Idea
.idea
# Mac OS
.DS_Store
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ clinic ask --help
-h | --help Display Help
-v | --version Display Version
--collect-only Do not process data on termination
--collect-delay Specify a delay(ms) before collecting data.
--visualize-only datapath Build or rebuild visualization from data
--on-port Run a script when the server starts listening on a port.
--autocannon Run the autocannon benchmarking tool when the server starts listening on a port.
Expand Down
7 changes: 0 additions & 7 deletions bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -485,16 +485,9 @@ async function runTool (args, Tool, version, uiOptions) {
}
}

// Validate usage of on-port flag
if (args['on-port'] > 0 && onPort) {
console.log('You must provide on-port with the autocannon config')
process.exit(0)
}

const openLocalFile = args.open && !args.upload

const tool = new Tool({
collectDelay: parseInt(args['collect-delay'], 10),
sampleInterval: parseInt(args['sample-interval'], 10),
detectPort: !!onPort,
dest: args.dest,
Expand Down
1 change: 0 additions & 1 deletion docs/clinic-doctor.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
-h | --help Display Help
-v | --version Display Version
--collect-only Do not process data on termination
--collect-delay Specify a delay(ms) before collecting data
--visualize-only datapath Build or rebuild visualization from data
--sample-interval interval Sample interval in milliseconds
--on-port Run a script when the server starts listening on a port.
Expand Down
1 change: 0 additions & 1 deletion docs/clinic-flame.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
-h | --help Display Help
-v | --version Display Version
--collect-only Do not process data on termination
--collect-delay Specify a delay(ms) before collecting data
--visualize-only datapath Build or rebuild visualization from data
--on-port Run a script when the server starts listening on a port.
--autocannon Run the autocannon benchmarking tool when the server starts listening on a port.
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
"clinic": "./bin.js"
},
"scripts": {
"test": "standard | snazzy && tap -j4 --timeout 0 --no-cov test/*.test.js",
"test-local": "standard | snazzy && tap -j4 --timeout 0 --no-cov test/*.test.js test-local/*.test.js",
"test": "standard | snazzy && tap -j1 --timeout 0 --no-cov test/*.test.js",
"test-local": "standard | snazzy && tap -j1 --timeout 0 --no-cov test/*.test.js test-local/*.test.js",
"ci-lint": "standard | snazzy",
"ci-test-no-cov": "tap -j4 --timeout 0 --no-cov test/*.test.js",
"ci-test-cov": "tap -j4 --timeout 0 test/*.test.js",
"ci-test-no-cov": "tap -j1 --timeout 0 --no-cov test/*.test.js",
"ci-test-cov": "tap -j1 --timeout 0 test/*.test.js",
"lint": "standard --fix | snazzy"
},
"dependencies": {
Expand Down

0 comments on commit 8f47ecd

Please sign in to comment.