Leave a clear line after spinner is stopped #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently after spinner is stopped it might leave behind the last symbol that was printed. This happens because '\b' is non-destructive in many terminal emulators. If '\n' is printed after spinner is done - the last printed symbol will remain printed (instead of an empty line). This happens because '\n' also happens to be non-destructive. VS Code is one example of such terminal emulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently after spinner is stopped it might leave behind the last symbol
that was printed. This happens because '\b' is non-destructive in many
terminal emulators. If '\n' is printed after spinner is done - the last
printed symbol will remain printed (instead of an empty line). This
happens because '\n' also happens to be non-destructive.
VS Code is one example of such terminal emulator.