Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a page for preview save the date from directus #69

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

NoeTerrier
Copy link
Contributor

The directus save_the_date object can be rendered on /save-the-date. This is WIP.

Close #68

The directus save_the_date object can be rendered on /save-the-date.
This is WIP.
@NoeTerrier NoeTerrier added the feature New feature or request label Aug 25, 2024
@NoeTerrier NoeTerrier self-assigned this Aug 25, 2024
@NoeTerrier NoeTerrier linked an issue Aug 25, 2024 that may be closed by this pull request
@NoeTerrier
Copy link
Contributor Author

For this PR, another PR on directus-config repo (clicepfl/directus-config#2) is required to be merged.

@NoeTerrier NoeTerrier marked this pull request as ready for review September 16, 2024 09:56
Copy link
Contributor

@SidonieBouthors SidonieBouthors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me :)

app/src/pages/save-the-date.tsx Show resolved Hide resolved
app/src/pages/save-the-date.tsx Show resolved Hide resolved
app/src/pages/save-the-date.tsx Show resolved Hide resolved
app/src/pages/save-the-date.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Thechi2000 Thechi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Thechi2000 Thechi2000 merged commit 91a099a into main Sep 18, 2024
3 checks passed
@Thechi2000 Thechi2000 deleted the 68-save-the-date-page branch September 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Save the date page
3 participants