kexec: reduce closure size #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Dec 26, 2021
| storeContents = [ | ||
| { object = config.system.build.kexec_script; symlink = "/kexec_nixos"; } | ||
| ]; | ||
| contents = []; | ||
| contents = [ | ||
| { source = image; target = image; } |
There was a problem hiding this comment.
We would also need this change in nixos-generators: @Lassulus
There was a problem hiding this comment.
maybe we should duplicate the code in nixos-generators at some point? but not sure
|
Some further fixes needed. |
The tarball was referring to ncurses, icu and glibc, which blow up the image to 1.4-1.5GB. With these changes the tarball is shrinked back to ~700MB.
Mic92
commented
Dec 26, 2021
| set -x | ||
| set -e | ||
| export TMPDIR=''${TMPDIR:-/} |
There was a problem hiding this comment.
With this change it also works in chroots.
|
notice me senpai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tarball was referring to ncurses, icu and glibc, which blow up the
image to 1.4-1.5GB. With these changes the tarball is shrinked back to
~700MB.