-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(/basic-rbac) add middleware, reorg and refactor copy #1560
Open
victoriaxyz
wants to merge
20
commits into
main
Choose a base branch
from
vi/docs-9178-test-guidesbasic-rbac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, here’s your docs preview: https://clerk.com/docs/pr/1560 |
victoriaxyz
changed the title
refactor content copy and flow, and code
refactor content copy and code
Sep 24, 2024
royanger
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide should probably get a further update, roughly as follows:
- Change
Create and protect an admin dashboard
to something akin toCreate and protect an admin dashboard via
page.tsx`` - Add a section like
Create and protect an admin dashboard via Middleware
- Be clear the developer only needs to pick one option for a route.
- Explain using the
checkRole()
function in Middleware to protect the entire route. Untested code:
import {
clerkMiddleware,
createRouteMatcher
} from '@clerk/nextjs/server';
import { checkRole } from "@/utils/roles";
const isAdminRoute = createRouteMatcher([
'/admin(.*)',
]);
export default clerkMiddleware((auth, req) => {
if (isAdminRoute(req) && !checkRole("admin")) auth().protect();
});
export const config = {
matcher: ['/((?!.*\\..*|_next).*)', '/', '/(api|trpc)(.*)'],
};
Aside from that suggestion, I dropped some thoughts and suggestion throughout the PR.
royanger
reviewed
Sep 25, 2024
victoriaxyz
commented
Sep 25, 2024
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
victoriaxyz
commented
Sep 25, 2024
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
Co-authored-by: Roy Anger <[email protected]>
victoriaxyz
commented
Sep 25, 2024
victoriaxyz
changed the title
refactor content copy and code
add middleware, reorg and refactor copy
Sep 26, 2024
alexisintech
changed the title
add middleware, reorg and refactor copy
(/basic-rbac) add middleware, reorg and refactor copy
Sep 27, 2024
alexisintech
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
Explanation:
This PR:
middleware.ts
section